Leveraging your Git workflow to improve quality and communication

Regatta view from Ca'Foscari / Canaletto

Jonathan Brinley

Modern Tribe

Flightless

2010

2016

You today !== You tomorrow
Vegetables in a Bowl, or, the Gardener / Giuseppe Arcimboldo

Prerequisite

Use version control

It should be Git

The Ninth Wave / Ivan Aivazovsky

Formal
&
Consistent

The Kindred Spirits / Asher Brown Durand
Modern Tribe code review workflow diagram

Modern Tribe’s Workflow

Agile Waterfall

Waterfall / M.C. Escher

Feature Branches

sprint workflow diagram

Hotfix Branch

hotfix workflow diagram

Branch?

Yes

Revolving House / Paul Klee
branch tree from github

Why am I here?

review before you code

Where are we going?

review while you code

Pull Request

Select a branch on github

Did we get there?

review after you code

Why?

  • Quality
  • Comfort
  • Mentorship
Bridge over a Pond of Water Lilies / Claude Monet

Code review: Security

  • User input
  • Browser output
  • Database queries
The Sea of Ice / Caspar David Friedrich

Code review: Performance

  • Database queries
  • Remote requests
  • Complex calculations
Ballet Rehearsal / Edgar Degas

Code review: coding standards

  • Format
  • Internationalization
  • Accessiblity
A Sunday Afternoon on the Island of La Grande Jatte / Georges-Pierre Seurat

Code review: maintainability

  • Architecture
  • Automated tests
  • Nomenclature
  • Documentation
Netherlandish Proverbs / Pieter Bruegel the Elder

Relax









The School of Athens / Raphael

Examples

Morning in a Pine Forest / Ivan Shishkin

Prioritize

Still Life with Apples and Oranges / Paul Cezanne

Wear hats

Park Restaurant / Auguste Macke

Resources

flightless.us/wcjax2016

Yellow Cow / Franz Marc

Jonathan Brinley

http://xplus3.net/ • jonathan@tri.be • @jbrinley

Modern Tribe

Flightless