Leveraging your Git workflow to improve quality and communication
Jonathan Brinley
2010
2016
You today !== You tomorrow
Prerequisite
Use version control
It should be Git
Formal
&
Consistent
Modern Tribe’s Workflow
Agile Waterfall
Feature Branches
Hotfix Branch
Branch?
Yes
Why am I here?
Where are we going?
Pull Request
Did we get there?
Why?
- Quality
- Comfort
- Mentorship
Code review: Security
- User input
- Browser output
- Database queries
Code review: Performance
- Database queries
- Remote requests
- Complex calculations
Code review: coding standards
- Format
- Internationalization
- Accessiblity
Code review: maintainability
- Architecture
- Automated tests
- Nomenclature
- Documentation
Relax
The School of Athens / Raphael
Examples
Prioritize
Wear hats
Resources
flightless.us/wcjax2016
- Learn Git Branching / Peter Cottle
- Git Tutorials / Atlassian
- Github for the Rest of Us / Morten Rand-Hendriksen
- What to look for in a Code Review / Trisha Gee
- Effective code reviews / Gareth Wilson
- Code Review Like You Mean It / Phil Haack
Jonathan Brinley
http://xplus3.net/ • [email protected] • @jbrinley